Added link_method parameter#589
Merged
Merged
Conversation
nickmelnikov82
requested review from
HammadTheOne and
alexcjohnson
as code owners
October 30, 2021 07:46
HammadTheOne
approved these changes
Nov 3, 2021
HammadTheOne
left a comment
HammadTheOne
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me 💃
My only suggestions are to add a CHANGELOG entry and a basic test for the link_method and this will be ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #578
About
Description of changes
Added link_method parameter to configure linking algorithm if link_fun is not set.